Skip to content

Conversation

@tsh-hashimoto
Copy link
Contributor

@tsh-hashimoto tsh-hashimoto commented Nov 14, 2024

There is a problem with this product:
If there is an OCCURS key item on the right hand of the WHEN conditional expression, a conversion error occurs.
This problem can be avoided by specifying a configuration file with the -conf option when executing cobj.

This pull request includes the addition of a new COBOL compiler configuration file and updates to the test suite to verify the new configuration settings. The most important changes are:

Configuration updates:

  • config/allow-key-in-rhs.conf: set yes to allow-search-key-in-rhs.
    • -> moved to tests/command-line-options.src/

Testing updates:

  • tests/command-line-options.src/conf.at: update to include new test cases for the allow-search-key-in-rhs configuration. These test cases check the behavior of COBOL programs with different configurations and ensure they compile correctly.

@tsh-hashimoto tsh-hashimoto marked this pull request as ready for review November 14, 2024 01:02
@yutaro-sakamoto
Copy link
Contributor

@tsh-hashimoto
Please move config/allow-key-in-rhs.conf to other directory (e.g. tests/command-line-options.src/).
Since compiler users refer to the config/ directory, any changes to the contents of the directory should be carefully considered.

@tsh-hashimoto
Copy link
Contributor Author

@yutaro-sakamoto Thank you for checking.
I moved allow-key-in-rhs.conf to tests/command-line-options.src/ (and a little fixed the test conf.at).

@yutaro-sakamoto yutaro-sakamoto merged commit 4436faa into opensourcecobol:develop Nov 14, 2024
124 checks passed
@tsh-hashimoto
Copy link
Contributor Author

memo

For actual use, don't use options, modify the item in /usr/share/opensource-cobol-4j-1.x.x/config/default.conf.

@yutaro-sakamoto yutaro-sakamoto mentioned this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants